fix: add throw exception for rsa salt

[vincentandreas]

What?

Implement throw exception in RSA PSS, when given salt length = 0, in Sign / Verify function

Why?

It improves UX and makes implementation predictable.

Checklist

• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests for my changes.
• I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

• I have added the correct milestone and labels to the PR.
• I have updated the release notes: link
• I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
• I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Issues #4265
Previous PR #4659

[AgnesToulet]

Hi! Sorry for the delay and thanks a lot for your contribution!

This looks good (just left some wording suggestions) and works great but we probably want to update the tests in this case to expect the error, could you update your PR with updated tests please?

[vincentandreas]

hi @AgnesToulet , thankyou for the feedback! I'll add that later.

[vincentandreas]

hi @AgnesToulet could you elaborate, which file that contain test that need to be updated?

[AgnesToulet]

It's the Webcrypto tests that need to be updated, you can see the failures here or running them locally.

Also, you'll need to split your lines into multiple lines to make the linter happy (it's complaining about the line length here).

[vincentandreas]

hi @AgnesToulet , I see, thankyou for that. sorry, I think I need more time to check & edit that within two weeks, is it okay?

[AgnesToulet]

Sure, thanks for taking care of this! Feel free to reach out if you have any question/need help.

[vincentandreas]

hi @AgnesToulet could you help to run the workflow? thankyou

[ankur22]

@vincentandreas looks like the build is failing. Can you double check that the code compiles and build into a binary?

[vincentandreas]

hi @ankur22 @AgnesToulet , thanks for noticing, here's the updated version, sorry for that. kindly help to retrigger the workflow, thanks

[vincentandreas]

hi @AgnesToulet @ankur22 for the gofmt I already update. but for this error, I need more time to understand this.
I think it's because the behavior of throw that changed (?).
link https://github.com/grafana/k6/actions/runs/19576035827/job/56062678604?pr=5132

[ankur22]

hi @AgnesToulet @ankur22 for the gofmt I already update. but for this error, I need more time to understand this. I think it's because the behavior of throw that changed (?). link https://github.com/grafana/k6/actions/runs/19576035827/job/56062678604?pr=5132

I'm taking a look. I believe these are flakey tests, so we might just be able to rerun then until they pass. I've just merged in master which contains some changes that might help too 🤞

[ankur22]

Yeah, the pipeline was failing due to flakey tests, which we're hoping to resolve soon 🤞 I'm happy with the current situation with the pipeline/

[vincentandreas]

hi @ankur22 I just update the branch with master, could you retrigger again?

[AgnesToulet]

LGTM, have you looked into checking that the functions throw an error instead of just skipping the tests?