Add support for extra-headers to cortextool rules commands #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akhmetov
force-pushed
the
alexander-akhmetov/extra-headers
branch
2 times, most recently
from
11d1f4a to
3df6428
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/extra-headers
branch
from
3df6428 to
9b13fd0
Compare
stevesg
approved these changes
Feb 27, 2025
|
Ah no worries actually, I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
--extra-headersto thecortextool rulescommands, similar to the existing parameter in mimirtool.This is needed for the new APIs in Grafana (example PR), which will allow loading rules with mimirtool and cortextool and converting them to Grafana rules. These APIs need some additional headers that can be currently set with mimirtool but not with cortextool.
Part of https://github.com/grafana/alerting-squad/issues/1031