forked from marian-nmt/marian-dev
-
Notifications
You must be signed in to change notification settings - Fork 0
oneDNN #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
graemenail
wants to merge
23
commits into
master
Choose a base branch
from
onednn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
oneDNN #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2239ba1 to
27a35b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
Replaces MKL with oneDNN. This PR should enable completely open-source releases of Marian.
This PR also includes a caching of boost, and a cleaning of the debug build directory. These can be broken off into a separate PR if necessary. During testing, windows builds would fail from running out of space building both debug and release. Since disabling oneDNN JIT profiling the build sizes are smaller.
Related: marian-nmt/marian-regression-tests#86
List of changes:
cblas_sgemm_batchinprod.cpp)mkl_somatcopyintensor_operators.cpp)mkl_somatcopyinpacked_gemm.cpp)The following have some MKL component, and have not been touched:
src/microsoftcodevs/*Added dependencies: Intel oneDNN (removing Intel MKL)
How to test
Ran the 1 million sentence testset of WNGT21 through the MKL (4672.1s) and oneDNN (3918.9s) versions.
Using the
wngt19model from regression tests.Setup
Ran
#cputagged regression tests. Non-intgemm tests pass.Regression test results
The static binaries are now larger.
Checklist