Skip to content

Conversation

pgupta751
Copy link
Contributor

extension to support unfolding expressions, along with test cases (c0 and vpr).

@pgupta751 pgupta751 requested review from ruiz-m and cliu369 March 30, 2025 19:52
@cliu369
Copy link
Contributor

cliu369 commented Apr 1, 2025

Maybe move all the not-unfolding-related test cases into src/test/resources/verifier/ instead?

@cliu369
Copy link
Contributor

cliu369 commented Apr 1, 2025

I would also suggest potentially updating the documentation for GVC0 to have unfolding - at least the language grammar and validation since I see you're at least changing the grammar and the validation.

There is some other documentation for which you may want to take a look at to see if you would like to change anything there:

@cliu369
Copy link
Contributor

cliu369 commented Apr 1, 2025

Otherwise it looks good to me!

just storing these locally on my computer for now, since I'm not sure how useful they are.
@pgupta751
Copy link
Contributor Author

Otherwise it looks good to me!

thanks for the review! I'll go ahead and merge now.

@pgupta751 pgupta751 merged commit a786b99 into master Apr 9, 2025
1 check failed
@pgupta751 pgupta751 deleted the unfolding branch April 9, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants