Update signing configuration for PGP subkey - #153
Merged
Conversation
After the move to a signing subkey, useInMemoryPgpKeys needs the key ID as its first argument, and the publishing build configuration needs to pass it as env.PGP_SIGNING_KEY_ID. See https://docs.gradle.org/current/userguide/signing_plugin.html#sec:subkeys Part of gradle/gradle-private#5321
blindpirate
marked this pull request as draft
August 21, 2026 10:43
blindpirate
marked this pull request as ready for review
August 21, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the move to a signing subkey following the August 14 security incident,
useInMemoryPgpKeysneeds the key ID as its first argument — without it the signing plugin falls back to the primary key.This adds the key ID to the
signing {}block and makes the publishing build configuration pass it asenv.PGP_SIGNING_KEY_ID, matching what was already done in gradle/gradle#38874, gradle/gradle-promote#382 and gradle/gradle-pom-properties#20.The
pgpSigningKeyIdTeamCity parameter is already defined on the parent project, so no new secret is needed.Docs: https://docs.gradle.org/current/userguide/signing_plugin.html#sec:subkeys
Part of gradle/gradle-private#5321