[newchem-cpp] calc_temp_cloudy: Refactor to call basic_gas_props#531
Open
mabruzzo wants to merge 60 commits into
Open
[newchem-cpp] calc_temp_cloudy: Refactor to call basic_gas_props#531mabruzzo wants to merge 60 commits into
calc_temp_cloudy: Refactor to call basic_gas_props#531mabruzzo wants to merge 60 commits into
Conversation
mabruzzo
force-pushed
the
ncc/calculate_temperature-basic_gas_props
branch
from
9dacb73 to
2fa76b8
Compare
This switches to using GRIMPL_NAMESPACE_DECL and puts all the helper function into the namespace
The result is definitely not bitwise identical, but that's not going to make tests fail (since the logic is not tested)
mabruzzo
force-pushed
the
ncc/calculate_temperature-basic_gas_props
branch
from
da72511 to
44776f8
Compare
mabruzzo
changed the title
calc_temp_cloudy_g: Refactor to call basic_gas_propscalc_temp_cloudy: Refactor to call basic_gas_props
mabruzzo
force-pushed
the
ncc/calculate_temperature-basic_gas_props
branch
from
44776f8 to
b635cf7
Compare
…e pointers to consts
This commit makes my_chemistry, primordial_cloudy_data, my_fields into pointers to const values (rather than raw pointers)
…temperature-basic_gas_props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #543 has been merged.
This is a simple single PR that follows up on #529 (and #533 and #543).
There are 2 commits:
basic_gas_propswithincalc_temp_cloudy_gcalc_temp_cloudy_gintocalculate_temperature.cpp(and rename it so that its now calledcalc_temp_cloudyWith a little refactoring, we refactor
calc_temp_cloudyso that it functions for bothprimordial_chemistry==0andprimordial_chemistry>0