-
Notifications
You must be signed in to change notification settings - Fork 75
Disable CI startup on fork branches #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -22,6 +22,7 @@ concurrency: | |||
jobs: | |||
test-graalvm-reachability-metadata: | |||
name: "Test GraalVM Reachability Metadata" | |||
if: ${{ github.repository == 'graalvm/native-build-tools' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is the correct syntax? We are using slightly different syntax in the Reachability metadata repository: https://github.com/oracle/graalvm-reachability-metadata/blob/master/.github/workflows/check-new-library-versions.yml#L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This syntax actually comes from https://github.com/graalvm/native-build-tools/blob/master/.github/workflows/deploy-snapshots.yml#L18 and I just want to be consistent across multiple files. Is there any issue I missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. My only question is what should I do if I want to run workflow on my fork to verify some changes?
- @dnestoro Both the current project and other projects I collaborate on use the Github Actions
workflow_dispatch
syntax in the CI configuration file, which means that a Job can be started directly from the github.com UI. Of course, start from the fork branch. - If you need to start all jobs, either open a PR at https://github.com/graalvm/native-build-tools/pulls .
- Or temporarily modify the configuration file of Github Actions in the fork branch. This means deleting the content of this PR.
Yes, you can trigger the workflow manually, but it won't pass the The only way how you can run jobs on your fork is if you remove lines added in this PR, right? |
|
.sdkmanrc
of the master branch #731 andnative-maven-plugin
lacksruntimeArgs
configuration item similar tonative-gradle-plugin
#685 ..sdkmanrc
of the master branch #731. We have discussed something similar at Restrict Github Actions Jobs from being executed on Forked branches oracle/graalvm-reachability-metadata#229.