Skip to content

Disable CI startup on fork branches #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented May 31, 2025

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 31, 2025
@@ -22,6 +22,7 @@ concurrency:
jobs:
test-graalvm-reachability-metadata:
name: "Test GraalVM Reachability Metadata"
if: ${{ github.repository == 'graalvm/native-build-tools' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is the correct syntax? We are using slightly different syntax in the Reachability metadata repository: https://github.com/oracle/graalvm-reachability-metadata/blob/master/.github/workflows/check-new-library-versions.yml#L21

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnestoro
Copy link
Collaborator

dnestoro commented Jun 2, 2025

This looks good to me. My only question is what should I do if I want to run workflow on my fork to verify some changes?

@melix @vjovanov @sdeleuze what do you think about this? Can this have any negative effects (for example on Spring or Micronaut).

@dnestoro dnestoro requested review from sdeleuze, melix and vjovanov June 2, 2025 11:54
Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. My only question is what should I do if I want to run workflow on my fork to verify some changes?

  • @dnestoro Both the current project and other projects I collaborate on use the Github Actions workflow_dispatch syntax in the CI configuration file, which means that a Job can be started directly from the github.com UI. Of course, start from the fork branch.
  • image
  • If you need to start all jobs, either open a PR at https://github.com/graalvm/native-build-tools/pulls .
  • Or temporarily modify the configuration file of Github Actions in the fork branch. This means deleting the content of this PR.

@dnestoro
Copy link
Collaborator

dnestoro commented Jun 2, 2025

Both the current project and other projects I collaborate on use the Github Actions workflow_dispatch syntax in the CI configuration file, which means that a Job can be started directly from the github.com UI

Yes, you can trigger the workflow manually, but it won't pass the if statement you added in this PR, and therefore the job won't run, right?

The only way how you can run jobs on your fork is if you remove lines added in this PR, right?

@linghengqian
Copy link
Contributor Author

Yes, you can trigger the workflow manually, but it won't pass the if statement you added in this PR, and therefore the job won't run, right?

The only way how you can run jobs on your fork is if you remove lines added in this PR, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants