Skip to content

Unmark suites and bump version to 24.2.1.1 #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mandrel/24.2
Choose a base branch
from

Conversation

Karm
Copy link
Collaborator

@Karm Karm commented Apr 26, 2025

This PR was automatically generated by mandrel-release.java of graalvm/mandrel-packaging!

@Karm Karm self-assigned this Apr 26, 2025
@Karm Karm requested review from galderz, jerboaa and zakkak April 26, 2025 22:46
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 26, 2025
@@ -4,8 +4,8 @@
"sourceinprojectwhitelist" : [],

"groupId" : "org.graalvm.compiler",
"version" : "24.2.1.0",
"release" : True,
"version" : "24.2.1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the script doing it, but we should probably change this to 24.2.2.0 over 24.2.1.1. The July release will likely be 24.2.2.0-Final.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we either bump straight to 24.2.2.0 and patch the version only if required to make a pre-CPU release or bump it to 24.2.1.1 now and bump it later to 24.2.2.0 (when merging upstream changes). The latter is what we have been doing so far. I am OK with either approach.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking is that we haven't done any in-between-cpu releases in quite some time. So I'd rather go with the more likely approach and deal with the uncommon version update (24.2.1.x in the current case) asynchronously as needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections to changing the scheme as long as it keeps being automated in: https://github.com/graalvm/mandrel-packaging/blob/master/release-scripts/mandrel-release.java

Perhaps could be wrapped up in the change: graalvm/mandrel-packaging#490 because not having this automated essentially makes the JDK 21 suite.py changes a manual effort...

Copy link

This PR appears to be stale because it has been open 30 days with no activity. This PR will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

@github-actions github-actions bot added the Stale label May 29, 2025
@zakkak zakkak removed the Stale label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants