feat(package/gqty): Allow subscription to all cache changes #2298
+58
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicary
force-pushed
the
feat(package/gqty)-cache-subscribe-all
branch
from
8ab1fdb to
b677797
Compare
vicary
force-pushed
the
feat(package/gqty)-cache-subscribe-all
branch
from
b677797 to
184e8ed
Compare
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@gqty/cli |
4.3.1-canary-20250913144609.184e8ed2c8cb8bc29df4d95faf656d3adaa99cf7 |
npm ↗︎ unpkg ↗︎ |
gqty |
4.0.0-canary-20250913144609.184e8ed2c8cb8bc29df4d95faf656d3adaa99cf7 |
npm ↗︎ unpkg ↗︎ |
@gqty/logger |
4.0.0-canary-20250913144609.184e8ed2c8cb8bc29df4d95faf656d3adaa99cf7 |
npm ↗︎ unpkg ↗︎ |
@gqty/react |
4.0.0-canary-20250913144609.184e8ed2c8cb8bc29df4d95faf656d3adaa99cf7 |
npm ↗︎ unpkg ↗︎ |
@gqty/solid |
1.0.0-canary-20250913144609.184e8ed2c8cb8bc29df4d95faf656d3adaa99cf7 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to allow global subscription to all cache changes in the GQty library, enabling listeners to be notified of any cache modifications without specifying specific paths.
- Added method overload to
subscribe()for global subscriptions that receive all cache change notifications - Updated cache notification logic to include global subscribers alongside path-specific subscribers
- Added comprehensive test coverage for the new global subscription functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/gqty/src/Cache/index.ts | Implements global subscription functionality with method overloads and notification updates |
| packages/gqty/test/cache.test.ts | Adds test coverage for global subscription behavior and updates existing test assertion |
| .changeset/pretty-bats-shave.md | Documents the feature addition as a major version change |
| .vscode/settings.json | Separates formatter configuration by language type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vicary
added a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.