Test createView and resolveTarget with TRANSIENT_ATTACHMENT#4635
Open
kainino0x wants to merge 1 commit intogpuweb:mainfrom
Open
Test createView and resolveTarget with TRANSIENT_ATTACHMENT#4635kainino0x wants to merge 1 commit intogpuweb:mainfrom
kainino0x wants to merge 1 commit intogpuweb:mainfrom
Conversation
|
Results for build job (at 24315d4): -webgpu:api,validation,createView:texture_view_usage:* - 452 cases, 2712 subcases (~6/case)
+webgpu:api,validation,createView:texture_view_usage:* - 452 cases, 2260 subcases (~5/case)
+webgpu:api,validation,createView:texture_view_usage_of_multiple_usages:* - 16 cases, 54 subcases (~3/case)
-webgpu:api,validation,render_pass,resolve:resolve_attachment:* - 21 cases, 21 subcases (~1/case)
+webgpu:api,validation,render_pass,resolve:resolve_attachment:* - 23 cases, 23 subcases (~1/case)
-TOTAL: 281182 cases, 2322747 subcases
+TOTAL: 281200 cases, 2322351 subcases |
This restriction is missing from the spec, but textures with TRANSIENT_ATTACHMENT must not be used as resolve targets. This must apply regardless of any usage subsetting in createView(). For simplicity (to better avoid bugs in validation elsewhere), it's proposed that createView() simply cannot subset a TRANSIENT_ATTACHMENT texture. This test implements that proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restriction is missing from the spec, but textures with TRANSIENT_ATTACHMENT must not be used as resolve targets.
This must apply regardless of any usage subsetting in createView(). For simplicity (to better avoid bugs in validation elsewhere), it's proposed that createView() simply cannot subset a TRANSIENT_ATTACHMENT texture. This test implements that proposal.
Issue: #4509; part of spec change gpuweb/gpuweb#6248
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.