docs(translation): Fix wrong import on example #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo Salmerón Robles <[email protected]>
rodgobbi
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Hi @gonzalosalmeron
Thanks for the PR 👍
But how does this improve documentation?
Removing will hide from developers that the react-day-picker re-exports date-fns/locale for convenience.
this is not the first time we get this feedback... but the export has been added in #2474 . Is there something wrong on our side? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for the great library! This PR fixes a naming conflict in the code examples.
What's Changed
react-day-picker/localeanddate-fns/locale.Type of Change
Additional Notes
This change improves clarity for developers using both libraries with localized calendars.