Skip to content

Support CNAME#114

Merged
VincentBean merged 1 commit intodevelopfrom
feature/cname-support
Mar 13, 2026
Merged

Support CNAME#114
VincentBean merged 1 commit intodevelopfrom
feature/cname-support

Conversation

@VincentBean
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CNAME DNS record support by introducing a CNAME record parser and adding a hasParser() guard to the Type enum to gracefully skip DNS record types that don't yet have a parser implementation during site import.

Changes:

  • Added a CNAME record parser class following the existing parser convention (using target as the field).
  • Added hasParser() method to the Type enum to check if a parser class exists for a given DNS type.
  • Updated ImportSite to skip DNS record types that lack a parser, preventing errors during import.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/dns/src/RecordParsers/CNAME.php New CNAME record parser extracting the target field
packages/dns/src/Enums/Type.php Added hasParser() method to dynamically check parser availability
packages/sites/src/Actions/ImportSite.php Added hasParser() guard to skip unsupported DNS types during import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@VincentBean VincentBean merged commit 4691092 into develop Mar 13, 2026
21 checks passed
@VincentBean VincentBean deleted the feature/cname-support branch March 13, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants