Skip to content

Fix #962 - use the title for the jUnit test case name - #1035

Merged
kgaughan merged 6 commits into
goss-org:masterfrom
manarth:issue-962
Aug 9, 2026
Merged

Fix #962 - use the title for the jUnit test case name#1035
kgaughan merged 6 commits into
goss-org:masterfrom
manarth:issue-962

Conversation

@manarth

@manarth manarth commented Sep 6, 2025

Copy link
Copy Markdown
Contributor

Description of change

Fix #962
This checks for the presence of a "title" attribute on the test-case, and uses that in the jUnit report if it is present.

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

@manarth
manarth requested a review from aelsabbahy as a code owner September 6, 2025 12:15

@kgaughan kgaughan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Also, could you merge from master and run the test suite to make sure there are no issues this change might cause?

Comment thread outputs/junit.go Outdated
Comment thread outputs/junit.go Outdated
Comment thread outputs/junit.go Outdated
Comment thread outputs/junit.go Outdated
Co-authored-by: Keith Gaughan <keith@gaughan.ie>
Comment thread outputs/junit.go Outdated
Comment thread outputs/junit.go Outdated

@kgaughan kgaughan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look fine aside from the flaky Windows tests, which will be fixed with #1103.

Thanks!

@kgaughan
kgaughan merged commit 4d7a908 into goss-org:master Aug 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JUNIT Test Report Generation - XML ​​File Improvement

2 participants