Skip to content

Fix/579 allday event date shift#731

Open
jorj-pineda wants to merge 4 commits intogoogleworkspace:mainfrom
jorj-pineda:fix/579-allday-event-date-shift
Open

Fix/579 allday event date shift#731
jorj-pineda wants to merge 4 commits intogoogleworkspace:mainfrom
jorj-pineda:fix/579-allday-event-date-shift

Conversation

@jorj-pineda
Copy link
Copy Markdown

@jorj-pineda jorj-pineda commented Apr 17, 2026

Description

Please include a summary of the change and which issue is fixed. If adding a new feature or command, please include the output of running it with --dry-run to prove the JSON request body matches the Discovery Document schema.

Dry Run Output:

// Paste --dry-run output here if applicable

Checklist:

  • My code follows the AGENTS.md guidelines (no generated google-* crates).
  • I have run cargo fmt --all to format the code perfectly.
  • I have run cargo clippy -- -D warnings and resolved all warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have provided a Changeset file (e.g. via pnpx changeset) to document my changes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 17, 2026

🦋 Changeset detected

Latest commit: 6091bd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where all-day calendar events were incorrectly shifting dates due to timezone offsets. By explicitly passing the user's timezone to the API and refining how event start and end times are extracted, the changes ensure that all-day events retain their original dates regardless of the user's local time settings.

Highlights

  • Timezone Handling: Updated the agenda command to pass the user's timezone to the Google Calendar API, ensuring accurate date representation.
  • Event Parsing Logic: Introduced a helper function to correctly distinguish between all-day and timed events, prioritizing the 'date' field to prevent unwanted timezone shifts.
  • API Response Schema: Added an 'allDay' boolean field to the processed event output to improve downstream handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where all-day calendar events displayed incorrect dates in the +agenda command. The fix involves passing the user's timezone as a query parameter to the Google Calendar API and introducing a new extract_event_times helper function that correctly prioritizes the date field for all-day events to prevent unintended timezone shifts. Additionally, unit tests were added to verify the time extraction logic. I have no feedback to provide as there were no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants