Skip to content

Conversation

hardik05
Copy link
Contributor

updated for shared memory support.

updated for shared memory support.
Copy link
Collaborator

@ifratric ifratric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One general comment that I have is that this changes the command line params for test_gdiplus.exe, so if we reference it anywhere in the documentation (IIRC we do in a couple of places, e.g. https://github.com/googleprojectzero/winafl/blob/master/readme_dr.md but possibly others), the documentation will be out-of-date and should be updated as well.

gdiplus.cpp Outdated
IStream* stream = SHCreateMemStream(reinterpret_cast<BYTE*>(sample_bytes), sample_size);
image = Gdiplus::Image::FromStream(stream);
}
if (image && (Ok == image->GetLastStatus())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems to be off here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying multiple options.. but for some reasons its just not working..

@hardik05 hardik05 marked this pull request as draft July 29, 2021 08:11
Copy link
Contributor Author

@hardik05 hardik05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to avoid indentation issue..

gdiplus.cpp Outdated
IStream* stream = SHCreateMemStream(reinterpret_cast<BYTE*>(sample_bytes), sample_size);
image = Gdiplus::Image::FromStream(stream);
}
if (image && (Ok == image->GetLastStatus())) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying multiple options.. but for some reasons its just not working..

@ifratric
Copy link
Collaborator

For me, it shows as having a 2 tab indentation whereas the line before has a single tab.

@ISH2YU
Copy link

ISH2YU commented Jun 7, 2025

one of the greatest feature of winafl of all time thank you sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants