[markFeatureWriter] Change markClassPrefix from “MC” to “mark”#974
Merged
anthrotype merged 1 commit intomainfrom Mar 9, 2026
Merged
[markFeatureWriter] Change markClassPrefix from “MC” to “mark”#974anthrotype merged 1 commit intomainfrom
anthrotype merged 1 commit intomainfrom
Conversation
Matches GlyphsApp prefix, which allows manual feature code that references auto-generated mark classes to be compiled by GlyphsApp and fontmake. See for #965 alternative approach and discussion.
This was referenced Mar 9, 2026
Member
|
ignore the ci failure, it's unrelated (i'll fix it) - thanks |
Collaborator
Author
|
The test expectations needed to be updated, fixed in #975 |
Member
|
thanks, I saw pkg_resources not found and pulled the trigger too fast |
Collaborator
Author
|
I was fooled by it too, but I ran the tox command locally to reproduce the build failure and it didn’t but the tests failed 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches GlyphsApp prefix, which allows manual feature code that references auto-generated mark classes to be compiled by GlyphsApp and fontmake.
See for #965 alternative approach and discussion.