[glyphs-reader] Treat empty Axis Mappings custom parameter as absent#1961
Merged
anthrotype merged 1 commit intomainfrom Apr 16, 2026
Merged
[glyphs-reader] Treat empty Axis Mappings custom parameter as absent#1961anthrotype merged 1 commit intomainfrom
anthrotype merged 1 commit intomainfrom
Conversation
An empty `"Axis Mappings" = {}` custom parameter was being returned as
`Some(empty_BTreeMap)`, causing `UserToDesignMapping::new()` to use it
as a valid (but empty) mapping and skip the instance-based fallback.
Fix: return `None` from `user_to_design_from_axis_mapping()` when the
resulting map is empty, matching glyphsLib's behaviour of treating an
empty dict as falsy.
Fixes #1830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
"Axis Mappings" = {}custom parameter was being returned asSome(empty_BTreeMap), causingUserToDesignMapping::new()to use it as a valid (but empty) mapping and skip the instance-based fallback.Fix: return
Nonefromuser_to_design_from_axis_mapping()when the resulting map is empty, matching glyphsLib's behaviour of treating an empty dict as falsy.Fixes #1830