[ufo2fontir] Fix UFO2 with @MMK_L_/@MMK_R_ kerning groups#1959
Merged
Conversation
Some fonts exported from older version of glyphs in UFO format use @MMK_L_X/@MMK_R_X kern group naming. Conversion from this naming scheme to public.kern1.X/public.kern2.X is provided by norad, but only runs when groups and kerning are loaded together. This patch first loads the metadata.plist to check if we're on an older version of UFO, and if we are it loads groups as well as kerning, so that the up-conversion code runs.
cmyr
force-pushed
the
upgrade-ufo-kerning
branch
from
5df2afc to
0647472
Compare
rsheeter
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fonts exported from older version of glyphs in UFO format use @MMK_L_X/@MMK_R_X kern group naming. Conversion from this naming scheme to public.kern1.X/public.kern2.X is provided by norad, but only runs when groups and kerning are loaded together.
This patch first loads the metadata.plist to check if we're on an older version of UFO, and if we are it loads groups as well as kerning, so that the up-conversion code runs.
fixes #1854