Skip to content
This repository was archived by the owner on Jun 9, 2020. It is now read-only.

CodeReviewInstruction

hiroshige-g edited this page Aug 31, 2015 · 3 revisions

Create and send a pull request

pywebsocket uses pull requests for reviewing.

  1. Fork pywebsocket, create a branch, commit modifications, and create/send a pull request. For how to create and send pull requests, see for example Using pull requests.
  2. Get an LGTM from the collaborators of pywebsocket.
  3. The collaborators of pywebsocket merge the pull request.

Run all unit tests

cd to the root directory of the repository, and run

$ python test/run_all.py --log_level debug -- -v

Check coding style

Run pep8

$ pep8 --repeat **/*.py

Release

Update version in setup.py, and commit.

Create a release.

Announce on the pywebsocket group.

Update DEPS in Chromium

Update the revision number part in the rule for pywebsocket

Update pywebsocket copy in the WebKit repository

http://trac.webkit.org/wiki/pywebsocket%3A%20a%20WebSocket%20server%20for%20layout%20tests

Clone this wiki locally