feat: expose universe_domain for tpc #1150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
product-auto-label
bot
added
size: m
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gkevinzheng
reviewed
Jul 21, 2025
Comment on lines
+215
to
+217
| credentials | ||
| and credentials.universe_domain != self.universe_domain | ||
| and self._emulator_host is None |
There was a problem hiding this comment.
Should this be in a function like validate_universe_domain instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better supports Trusted Partner Cloud (TPC) by exposing
universe_domainandapi_endpointproperties.Universe domain was already supported by Bigtable by passing it in with
client_options, but reading it back later was not easily accessible. This PR changes thatI also added a ValueError to be raised if the universe_domain set in the provided
credentialsfile differs from the one passed inclient_optionsNote: This feature requires a minimum version update for google-auth, since we need access to the credential's
universe_domainto properly validate that it matches the user input, to avoid accidentally sending data to the wrong universe_domain