-
Notifications
You must be signed in to change notification settings - Fork 63
feat: add support for AddToCell in Data Client #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for AddToCell in Data Client #1147
Conversation
Thanks for putting this together! Do you think you could also add a system test like this, to make sure it works as we expect end-to-end? Edit: Actually, I ended up putting this together myself. You can copy it in: axyjo/python-bigtable@axyjo-data-client-add-to-cell...googleapis:python-bigtable:data-client-add-to-cell-system-tests |
In case you miss my edit: I put together a system test for this. It would be great if you could merge that in here |
Thanks, @daniel-sanche + @mutianf! Just addressed your feedback + cherry-picked Daniel's changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small change, then it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (after checks pass). Thanks for putting this together!
Sorry, one more change: It looks like some tests are breaking because of the new column family in the system tests. Can you apply this diff to fix the CI? (It also adds another unit test as well) |
@daniel-sanche apologies for the delay -- just pushed up those changes :) |
@daniel-sanche I think these Kokoro failures are unrelated to the changes, right? |
Yes, we can ignore those sample failures Just merged, thanks for all your work on this! |
Thanks for your help w/ the system tests! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1146 🦕