feat: setup SQLCommenter and allow client metadata #3064
Open
AjmeraParth132 wants to merge 1 commit intogoogleapis:mainfrom
Open
feat: setup SQLCommenter and allow client metadata #3064AjmeraParth132 wants to merge 1 commit intogoogleapis:mainfrom
AjmeraParth132 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces SQLCommenter support to the MCP Toolbox, allowing SQL statements to be annotated with metadata such as trace information, client attributes, and server versions. The changes include a new sqlcommenter package, updates to various database source implementations to append these comments, and new configuration flags to enable the feature. A critical issue was identified in the sqlcommenter implementation where the comment format and separators did not align with the standard SQLCommenter specification or the provided unit tests; specifically, it used colons and semicolons instead of the required equals signs and commas.
Contributor
|
/gcbrun |
AjmeraParth132
changed the title
AjmeraParth132
force-pushed
the
feat/sql-commenter
branch
from
e673c8f to
30b2e7f
Compare
anubhav756
force-pushed
the
feat/sql-commenter
branch
from
30b2e7f to
94a1d99
Compare
Contributor
|
/gcbrun |
anubhav756
force-pushed
the
feat/sql-commenter
branch
from
94a1d99 to
0f9ecc3
Compare
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #3061