fix(tools/bigquery-execute-sql): avoid surfacing invalid queries as MCP 500s#3056
fix(tools/bigquery-execute-sql): avoid surfacing invalid queries as MCP 500s#3056jack-larch wants to merge 4 commits intogoogleapis:mainfrom
Conversation
…CP 500s Route dry-run BigQuery validation failures through the shared GCP error processor so normal query mistakes are returned as tool errors instead of transport-level internal errors. Made-with: Cursor
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery SQL execution tool to use a centralized GCP error processing utility, util.ProcessGcpError, instead of a generic internal server error for query validation failures. Additionally, it introduces unit tests for ProcessGcpError to ensure correct mapping of GCP errors to AgentError or ClientServerError based on status codes and error reasons. I have no feedback to provide.
duwenxin99
left a comment
There was a problem hiding this comment.
@jack-larch Thanks for opening the PR! Could you make sure to sign the CLA? Thanks!
|
/gcbrun |
|
/gcbrun |
Description
Route
bigquery-execute-sqldry-run validation failures through the shared GCP error processor instead of hardcoding them as internal server errors.This keeps normal BigQuery query mistakes in the tool-error path rather than escalating them into MCP transport failures.
PR Checklist
!if this involve a breaking changeNotes:
go testlocally in this environment because the Go toolchain is not installed on this machine.ProcessGcpErrorso the intended classification is explicit in CI.🛠️ Fixes #3055
Made with Cursor