fix(tool/bigquery): handle omitted optional parameters with typed NULLs#3051
Open
Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Open
fix(tool/bigquery): handle omitted optional parameters with typed NULLs#3051Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery SQL tool to better handle optional parameters and NULL values by introducing a dedicated buildQueryParameters function. It also adds comprehensive unit tests for parameter building. The review feedback correctly identifies a potential issue with named parameter detection using simple string containment, which could lead to false positives, and suggests handling the TypeMap parameter type to prevent potential nil pointer issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a runtime
bigquery: nil parametererror that occurred when optional parameters were omitted in BigQuery tool calls. The issue was caused by the tool sending untypednilvalues to the BigQuery API, which the SDK does not accept for parameters.Impact:
IS NULLlogic and optional filters in BigQuery SQL statements.Summary of Solution:
nilvalues to specific BigQuery SDK types (NullString,NullInt64,NullFloat64,NullBool).NullFieldshandling for the low-level REST client to ensureNULLvalues are correctly marshaled during dry runs.bigquerysql_invoke_test.goto validate mapping for all supported scalar and collection types.PR Checklist
!if this involve a breaking change🛠️ Fixes #3033