refactor(tools): add ScopesRequired to Tool config and interface#3048
Open
duwenxin99 wants to merge 2 commits intomainfrom
Open
refactor(tools): add ScopesRequired to Tool config and interface#3048duwenxin99 wants to merge 2 commits intomainfrom
ScopesRequired to Tool config and interface#3048duwenxin99 wants to merge 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a GetScopesRequired method to the Tool interface and implements it across all database tools by adding a ScopesRequired field to their configurations. Feedback highlights redundant field declarations in the serverlessspark tools due to struct embedding and an inconsistent method receiver type in serverlesssparkcancelbatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Tool config and interfacor to enable MCP tool-level auth