feat(tool/looker): add conversation CRUD tools#3032
feat(tool/looker): add conversation CRUD tools#3032hiracky16 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces five new Looker tools for managing conversation sessions: looker-create-conversation, looker-delete-conversation, looker-get-conversation, looker-list-conversations, and looker-update-conversation. The implementation includes the necessary Go logic, unit tests, and documentation for each tool. Several issues were identified regarding logging practices, specifically the use of ErrorContext for informational messages and the lack of structured key-value pairs. Additionally, the documentation titles need to be updated to follow the repository's naming convention, and mutating tools like 'create' and 'update' should include the DestructiveHint annotation for consistency. Finally, the imports in cmd/internal/imports.go should be reordered alphabetically.
24c80e8 to
a4eaa64
Compare
1. Description
This PR implements the Phase 1 of Looker's Conversational Analytics API integration by adding five tools for Conversation CRUD management. These tools follow the established patterns and the strict security/annotation guidelines established in PR #2830.
New Tools Added:
looker-create-conversation: Starts a new session with an AI agent.looker-list-conversations: Searches and lists existing conversation sessions.looker-get-conversation: Retrieves detailed metadata for a specific session.looker-update-conversation: Modifies conversation attributes (e.g., name).looker-delete-conversation: Deletes a conversation session (marked withDestructiveHint).Key Highlights:
ReadOnlyHintandDestructiveHintin theInitializemethod to ensure safe LLM interaction.docs/en/integrations/looker/tools/with correct H2 ordering and required shortcodes.2. PR Checklist
!if this involves a breaking change (N/A, additive only)3. Issue Reference
Related to the work on Looker Conversational Analytics integration. 🦕