Skip to content

feat(tool/looker): add conversation CRUD tools#3032

Open
hiracky16 wants to merge 1 commit intogoogleapis:mainfrom
hiracky16:feat/add-looker-conversation-crud
Open

feat(tool/looker): add conversation CRUD tools#3032
hiracky16 wants to merge 1 commit intogoogleapis:mainfrom
hiracky16:feat/add-looker-conversation-crud

Conversation

@hiracky16
Copy link
Copy Markdown
Contributor

1. Description

This PR implements the Phase 1 of Looker's Conversational Analytics API integration by adding five tools for Conversation CRUD management. These tools follow the established patterns and the strict security/annotation guidelines established in PR #2830.

New Tools Added:

  • looker-create-conversation: Starts a new session with an AI agent.
  • looker-list-conversations: Searches and lists existing conversation sessions.
  • looker-get-conversation: Retrieves detailed metadata for a specific session.
  • looker-update-conversation: Modifies conversation attributes (e.g., name).
  • looker-delete-conversation: Deletes a conversation session (marked with DestructiveHint).

Key Highlights:

  • Annotation Protection: Strictly adheres to PR feat(tools/looker): Looker agent management from MCP #2830 patterns by forcing ReadOnlyHint and DestructiveHint in the Initialize method to ensure safe LLM interaction.
  • Documentation: Added CI-compliant markdown files in docs/en/integrations/looker/tools/ with correct H2 ordering and required shortcodes.
  • Testing: Unit tests verify correct configuration parsing for all new tools.

2. PR Checklist

  • Make sure to open an issue as a bug/issue before writing your code!
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Make sure to add ! if this involves a breaking change (N/A, additive only)

3. Issue Reference

Related to the work on Looker Conversational Analytics integration. 🦕

@hiracky16 hiracky16 marked this pull request as ready for review April 11, 2026 22:11
@hiracky16 hiracky16 requested review from a team as code owners April 11, 2026 22:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces five new Looker tools for managing conversation sessions: looker-create-conversation, looker-delete-conversation, looker-get-conversation, looker-list-conversations, and looker-update-conversation. The implementation includes the necessary Go logic, unit tests, and documentation for each tool. Several issues were identified regarding logging practices, specifically the use of ErrorContext for informational messages and the lack of structured key-value pairs. Additionally, the documentation titles need to be updated to follow the repository's naming convention, and mutating tools like 'create' and 'update' should include the DestructiveHint annotation for consistency. Finally, the imports in cmd/internal/imports.go should be reordered alphabetically.

Comment thread internal/tools/looker/lookergetconversation/lookergetconversation.go Outdated
Comment thread internal/tools/looker/lookerlistconversations/lookerlistconversations.go Outdated
Comment thread internal/tools/looker/lookerupdateconversation/lookerupdateconversation.go Outdated
Comment thread internal/tools/looker/lookerupdateconversation/lookerupdateconversation.go Outdated
Comment thread internal/tools/looker/lookerlistconversations/lookerlistconversations.go Outdated
Comment thread docs/en/integrations/looker/tools/looker-update-conversation.md Outdated
Comment thread docs/en/integrations/looker/tools/looker-list-conversations.md Outdated
Comment thread docs/en/integrations/looker/tools/looker-get-conversation.md Outdated
Comment thread docs/en/integrations/looker/tools/looker-delete-conversation.md Outdated
@hiracky16 hiracky16 requested review from a team as code owners April 14, 2026 22:05
@hiracky16 hiracky16 force-pushed the feat/add-looker-conversation-crud branch from 24c80e8 to a4eaa64 Compare April 14, 2026 22:23
@drstrangelooker drstrangelooker added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants