Skip to content

ci(build): migrate macOS SDK to internal GCS bucket for security#3025

Merged
duwenxin99 merged 5 commits intomainfrom
macos-sdk
Apr 16, 2026
Merged

ci(build): migrate macOS SDK to internal GCS bucket for security#3025
duwenxin99 merged 5 commits intomainfrom
macos-sdk

Conversation

@duwenxin99
Copy link
Copy Markdown
Contributor

@duwenxin99 duwenxin99 commented Apr 10, 2026

Migrate the MacOS SDK from a third-party GitHub repository to a private GCS bucket for release build.

@duwenxin99 duwenxin99 requested a review from a team as a code owner April 10, 2026 18:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Cloud Build configurations for both continuous and versioned releases. Key changes include switching the macOS SDK download source to a private Google Cloud Storage bucket, standardizing YAML formatting, and updating build flags. Feedback is provided regarding incorrect bucket name substitutions for versioned releases, an unnecessary volume mount in a Windows build step, and a suggestion to avoid multi-line environment variable strings for better maintainability.

Comment thread .ci/versioned.release.cloudbuild.yaml Outdated
Comment thread .ci/continuous.release.cloudbuild.yaml Outdated
Comment thread .ci/versioned.release.cloudbuild.yaml Outdated
@duwenxin99 duwenxin99 enabled auto-merge (squash) April 16, 2026 15:08
@duwenxin99 duwenxin99 merged commit 76617b2 into main Apr 16, 2026
18 checks passed
@duwenxin99 duwenxin99 deleted the macos-sdk branch April 16, 2026 15:42
@github-actions
Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-3025 have been deleted.

github-actions bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Apr 16, 2026
…ity (googleapis#3025)

Migrate the MacOS SDK from a third-party GitHub repository to a private
GCS bucket for release build. 76617b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants