feat(internal/librarian/nodejs): update existing library for new API paths#5998
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Node.js libraries, including logic to associate new API paths with existing libraries by comparing versionless paths. Feedback was provided regarding the versionless helper function, which fails to correctly handle trailing slashes, potentially leading to incorrect matches. Additionally, a suggestion was made to ensure unique test case names in the new Node.js test suite for better clarity.
…paths The "librarian add" command is updated to add a new API path to an existing library for nodejs when the new path matches a path in that library, modulo the version at the end. More subtelty may be needed later, but this will handle simple situations as well as putting in place the framework for later logic to fit into. Towards googleapis#5971
jskeet
force-pushed
the
nodejs-update-existing
branch
from
868899a to
5a9cde1
Compare
jskeet
changed the title
quirogas
approved these changes
May 14, 2026
sofisl
pushed a commit
that referenced
this pull request
May 14, 2026
…paths (#5998) The "librarian add" command is updated to add a new API path to an existing library for nodejs when the new path matches a path in that library, modulo the version at the end. More subtelty may be needed later, but this will handle simple situations as well as putting in place the framework for later logic to fit into. Towards #5971
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "librarian add" command is updated to add a new API path to an existing library for nodejs when the new path matches a path in that library, modulo the version at the end.
More subtelty may be needed later, but this will handle simple situations as well as putting in place the framework for later logic to fit into.
Towards #5971