fix(swift): add pagination overloads to service protocol#5993
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Swift mustache templates to use 'any AsyncSequence' instead of 'some AsyncSequence' for pagination method signatures. It also modifies the service protocol template to conditionally include pagination and pagination-options method signatures, including their documentation lines, within the REST method definitions. I have no feedback to provide.
sofisl
pushed a commit
that referenced
this pull request
May 14, 2026
The paginated overloads for RPCs should be included in the service's protocol functions. Note: a protocol return type within a protocol MUST be `any` because there is no way for the compiler to infer the return type. This also means that the implementation cannot specify `some` because it does not match the function signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paginated overloads for RPCs should be included in the service's protocol functions.
Note: a protocol return type within a protocol MUST be
anybecause there is no way for the compiler to infer the return type. This also means that the implementation cannot specifysomebecause it does not match the function signature.