refactor: rename isVeneer to isMixedLibrary#5992
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes terminology by renaming "veneer" and "module" to "mixed library" across the librarian's internal logic for Rust, Swift, and Node.js. The review feedback identifies several remaining instances of the old terminology in error messages and comments that require updating for consistency. Additionally, a logical contradiction was noted in the documentation regarding the skip_generate flag for mixed libraries.
|
@coryan here is a crack at aligning/improving things here...naming is hard...idk if I like this either, but if I squint and tilt my head juuuust right... |
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I like this better. I don't believe any name would be perfect, but this is a better match for more cases than the previous one. Thanks
2 participants
Aligns
isVeneerand associated helpers naming aroundMixedLibraryconcept - a library which contains handwritten code, potentially mixed with generated code. It's a bit more "on the nose" than "isVeneer".Fixes #5733