fix(internal/librarian/java): collectModules should respect configs to skip certain modules#5983
Open
zhumin8 wants to merge 3 commits into
Open
fix(internal/librarian/java): collectModules should respect configs to skip certain modules#5983zhumin8 wants to merge 3 commits into
zhumin8 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces conditional logic for generating Java modules in the librarian service. It updates the module discovery and collection processes to respect configuration flags such as GenerateGAPIC, GenerateResourceNames, and GenerateProtoGRPC, allowing for granular control over which artifacts (Client, Proto, or gRPC) are produced. Additionally, comprehensive test cases have been added to pom_test.go to verify these conditional generation paths. I have no feedback to provide as there were no review comments to evaluate.
zhumin8
force-pushed
the
fix-proto-grpc-pom
branch
from
62c8aa2 to
15baea2
Compare
sofisl
reviewed
May 14, 2026
| if err != nil { | ||
| return nil, err | ||
| if shouldGenerateClient { | ||
| clientDir := filepath.Join(libraryDir, libCoord.GAPIC.ArtifactID) |
Contributor
There was a problem hiding this comment.
is it possible this isn't a path? if so should we check that before isPOMMissing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect configs (generate_proto_grpc, generate_gapic and generate_resource_names) to skip certain module generation when collecting expected modules.
collectModulesis used to identify new modules to add to versions.txt and to update pom.xml.context #5730 (comment)
Fix #5730