feat(internal/librarian/python): parallelize Python generation#5860
Merged
Conversation
Generation of each package is now performed within a package-specific tmp directory, with a symlink to fulfil synthtool expectations. The code calling python.Generate within internal/librarian is now parallelized. See go/sdk:librarian-python-parallel-generation for more details around the design of the tmp directory. Fixes googleapis#3728
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request parallelizes Python library generation by introducing a temporary generationRoot directory for each package, isolating concurrent generation and post-processing tasks. Review feedback recommends using defer to guarantee the cleanup of these temporary directories in case of failures and suggests explicitly removing any pre-existing tmp directory to ensure the generation process is idempotent.
noahdietz
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generation of each package is now performed within a package-specific tmp directory, with a symlink to fulfil synthtool expectations. The code calling python.Generate within internal/librarian is now parallelized.
See go/sdk:librarian-python-parallel-generation for more details around the design of the tmp directory.
Fixes #3728