chore(tool/cmd/migrate): remove hardcoded excluded_protos for google/rpc#5828
Merged
zhumin8 merged 1 commit intogoogleapis:mainfrom May 5, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the specific override for the "google/rpc" path in the Java proto migration logic, which previously excluded "google/rpc/http.proto". The corresponding test case in java_test.go has also been removed. I have no feedback to provide as there were no review comments to evaluate.
noahdietz
approved these changes
May 5, 2026
sofisl
pushed a commit
that referenced
this pull request
May 5, 2026
…rpc (#5828) Remove hardcoded exclusion for `google/rpc` to keep in sync with recent changes in google-cloud-java. See googleapis/google-cloud-java#12992 and googleapis/google-cloud-java#13005 Fix #5803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove hardcoded exclusion for
google/rpcto keep in sync with recent changes in google-cloud-java. See googleapis/google-cloud-java#12992 and googleapis/google-cloud-java#13005Fix #5803