feat(gax): add ApiCallContext and request-level settings overloads to ResumableUploadCallable - #14251
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
2 times, most recently
from
September 4, 2026 03:01
fc4a138 to
3a29329
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
5 times, most recently
from
September 4, 2026 22:09
61f6c53 to
a55db92
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 4, 2026 22:35
a55db92 to
26f88bb
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 4, 2026 23:35
26f88bb to
38e3b32
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 5, 2026 00:51
38e3b32 to
b599050
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
2 times, most recently
from
September 9, 2026 15:50
1463b4d to
9cd06c0
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 9, 2026 20:15
9cd06c0 to
ade4784
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 10, 2026 01:14
ade4784 to
90370f3
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 10, 2026 18:34
90370f3 to
f13af44
Compare
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
2 times, most recently
from
September 11, 2026 17:22
2ffc81d to
e688e1c
Compare
blakeli0
reviewed
Sep 11, 2026
| * @param settings request-level call settings overrides; may be {@code null} | ||
| * @return future for tracking and controlling the upload | ||
| */ | ||
| public ResumableUploadFuture<ResponseT> futureCall( |
Contributor
There was a problem hiding this comment.
I'm leaning towards only expose two methods for now.
futureCall(RequestT request, InputStream payload, @Nullable ResumableUploadCallSettings settings)
and
futureCall(RequestT request, InputStream payload, @Nullable ApiCallContext context, @Nullable ResumableUploadCallSettings settings).
This is inline with other callables that most of them expose two methods. One with ApiCallContext, one without it. We could try to expose more at the generated client level later.
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 11, 2026 19:59
e688e1c to
efd92b6
Compare
whowes
marked this pull request as ready for review
September 11, 2026 20:03
blakeli0
approved these changes
Sep 11, 2026
… ResumableUploadCallable Add 2-, 3-, and 4-argument overloads to ResumableUploadCallable for futureCall and resumeCall, supporting: 1. Default context and settings (used by generated ServiceClient convenience methods). 2. Per-request ApiCallContext overrides for transport metadata (extra headers, credentials). 3. Per-request ResumableUploadCallSettings overrides for state-machine knobs. 4. Full method accepting both call context and settings overrides. ResumableUploadCallableImpl performs a 3-tier precedence merge on settings and merges ApiCallContext.
whowes
force-pushed
the
whowes/resumable-upload-call-context
branch
from
September 11, 2026 21:12
efd92b6 to
bdd7a62
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to meet the resumable upload requirement to allow custom headers and other settings to be applied on a per-call basis.