feat(gax): add ResumableUploadCallable creation to Callables and HttpJsonCallableFactory - #14242
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aef944f to
8cca7df
Compare
8cca7df to
13ed5aa
Compare
13ed5aa to
cb17291
Compare
3c30fa0 to
f88f691
Compare
f88f691 to
c36a2ad
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for resumable uploads in the HTTP/JSON transport layer by adding the createResumableUploadCallable factory method to HttpJsonCallableFactory and the resumableUpload utility method to Callables. Corresponding unit tests have also been added to verify their behavior. There are no review comments, so I have no feedback to provide.
c36a2ad to
00173b2
Compare
00173b2 to
34f02d0
Compare
34f02d0 to
83aee5d
Compare
3dbcc23 to
61e6adb
Compare
73a0620 to
c46f507
Compare
7253511 to
81c60ca
Compare
81c60ca to
5d99a59
Compare
| ResumableUploadCallSettings callSettings, | ||
| ClientContext clientContext) { | ||
| return new ResumableUploadCallableImpl<>( | ||
| uploadClient, callSettings, clientContext.getDefaultCallContext()); |
There was a problem hiding this comment.
A callable should take the whole ClientContext, not ApiCallContext which is scoped to a single call.
There was a problem hiding this comment.
Thanks for catching, done. (The ResumableUploadCallableImpl constructor is changed in #14241 since it's not merged yet.)
5d99a59 to
8cf9f8d
Compare
…JsonCallableFactory
8cf9f8d to
a7d49c9
Compare
|
|
2 participants
This change wires up the minimal Callable implementation from #14241 into the relevant existing factory classes.