refactor(gax): add startUnaryCall to HttpJsonClientCalls - #14136
Draft
whowes wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors HttpJsonClientCalls.java by extracting the logic for starting a unary call from futureUnaryCall into a new helper method, startUnaryCall. This new method accepts a custom HttpJsonClientCall.Listener parameter, allowing for more flexible call handling, while futureUnaryCall is updated to delegate to this helper. There are no review comments, and I have no feedback to provide.
whowes
changed the title
whowes
changed the title
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 21, 2026 00:37
abf6f55 to
37eaf01
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpJsonClientCalls currently allows callers access to the HTTP response body. The newly-added startUnaryCall allows callers to provide a Listener that allows action based on status codes and headers, both of which are needed for resumable uploads.