feat(gax): add HTTP/JSON implementation of ResumableUploadClient.startUpload - #14091
Closed
whowes wants to merge 1 commit into
Closed
feat(gax): add HTTP/JSON implementation of ResumableUploadClient.startUpload#14091whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
whowes
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/string-http-response-parser
branch
from
August 17, 2026 23:04
67ced68 to
a2f2378
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
3 times, most recently
from
August 17, 2026 23:44
16d875f to
e808397
Compare
whowes
changed the base branch from
whowes/string-http-response-parser
to
whowes/resumable-upload-client
August 17, 2026 23:46
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 17, 2026 23:58
e808397 to
dbd35b6
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 17, 2026 23:58
003083c to
34d9c14
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 18, 2026 00:03
dbd35b6 to
1435243
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 00:03
34d9c14 to
68cadaf
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 18, 2026 00:19
1435243 to
880655e
Compare
Contributor
Author
|
/gemini review |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 18, 2026 00:28
880655e to
2ad83c8
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 00:35
68cadaf to
c07069b
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 18, 2026 00:35
2ad83c8 to
2937dba
Compare
whowes
added
the
kokoro:force-run
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 18, 2026 21:51
2937dba to
f551afe
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 18, 2026 22:52
8a4d18e to
8ca4f84
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 18, 2026 23:39
1d39523 to
8f5e0d3
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 23:39
8ca4f84 to
4030840
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 19, 2026 15:59
8f5e0d3 to
b3d0b13
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 19, 2026 15:59
4030840 to
087c159
Compare
|
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 19, 2026 16:22
b3d0b13 to
62fbb8c
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 19, 2026 17:15
5a27f29 to
8765335
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 19, 2026 18:24
37b56c9 to
b4e8162
Compare
Contributor
Author
|
/gemini review |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 19, 2026 20:07
b4e8162 to
ccfc57f
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 19, 2026 20:07
202c82a to
2c264da
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 19, 2026 20:12
ccfc57f to
dfe0617
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the HttpJsonResumableUploadClient class and its corresponding unit tests to support resumable uploads over HTTP/JSON. The reviewer suggested a minor code cleanup to remove a redundant cast to HttpJsonCallContext when setting up the call context.
Comment on lines
+125
to
+130
| HttpJsonCallContext context = | ||
| (HttpJsonCallContext) | ||
| HttpJsonCallContext.createDefault() | ||
| .nullToSelf(clientContext.getDefaultCallContext()) | ||
| .merge(inputContext) | ||
| .withExtraHeaders(START_UPLOAD_HEADERS); |
Contributor
There was a problem hiding this comment.
The cast to HttpJsonCallContext is redundant because HttpJsonCallContext.createDefault(), nullToSelf(), merge(), and withExtraHeaders() all return HttpJsonCallContext (or covariant subtypes thereof), meaning the entire chain already evaluates to HttpJsonCallContext.
HttpJsonCallContext context =
HttpJsonCallContext.createDefault()
.nullToSelf(clientContext.getDefaultCallContext())
.merge(inputContext)
.withExtraHeaders(START_UPLOAD_HEADERS);
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 19, 2026 21:57
dfe0617 to
3655e2e
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 19, 2026 21:57
2c264da to
c0e396a
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬