Skip to content

deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison}#13007

Draft
diegomarquezp wants to merge 2 commits intomainfrom
fix/common-protos-junit-version
Draft

deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison}#13007
diegomarquezp wants to merge 2 commits intomainfrom
fix/common-protos-junit-version

Conversation

@diegomarquezp
Copy link
Copy Markdown
Contributor

Fixes observed failures in last nightly graalvm runs

The failure is as follows:

07:21:37:407 [ERROR] Failed to execute goal on project proto-google-common-protos: Could not resolve dependencies for project com.google.api.grpc:proto-google-common-protos:jar:2.71.0-SNAPSHOT: The following artifacts could not be resolved: junit:junit:jar:5.11.4 (absent): Could not find artifact junit:junit:jar:5.11.4 in maven-central (https://repo1.maven.org/maven2) -> [Help 1]

Due to junit:junit being 4.x api. For 5.x we use the junit:junit-bom

@diegomarquezp diegomarquezp changed the title deps: use JUnit 5 artifact ID as per ${junit.verison} deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison} May 5, 2026
@diegomarquezp diegomarquezp changed the title deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison} deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison} May 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JUnit dependency in java-common-protos/pom.xml from junit:junit to org.junit:junit-bom. A critical issue was identified regarding the declaration of the junit-bom artifact: as a Bill of Materials (BOM), it requires the addition of pom and import to prevent Maven from attempting to resolve it as a JAR file, which would lead to a build failure.

Comment thread java-common-protos/pom.xml Outdated
@diegomarquezp
Copy link
Copy Markdown
Contributor Author

  • Investigate why only on GraalVM.
  • Try local reproduction
  • Find out whether there common-protos is a special case in the builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant