deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison}#13007
Draft
diegomarquezp wants to merge 2 commits intomainfrom
Draft
deps(common-protos): use JUnit 5 artifact ID as per ${junit.verison}#13007diegomarquezp wants to merge 2 commits intomainfrom
${junit.verison}#13007diegomarquezp wants to merge 2 commits intomainfrom
Conversation
${junit.verison}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the JUnit dependency in java-common-protos/pom.xml from junit:junit to org.junit:junit-bom. A critical issue was identified regarding the declaration of the junit-bom artifact: as a Bill of Materials (BOM), it requires the addition of pom and import to prevent Maven from attempting to resolve it as a JAR file, which would lead to a build failure.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes observed failures in last nightly graalvm runs
The failure is as follows:
Due to
junit:junitbeing 4.x api. For 5.x we use thejunit:junit-bom