Skip to content

test(spanner): fix MutableCredentialsExample sample#13006

Merged
sakthivelmanii merged 1 commit intomainfrom
fix_spanner_samples
May 5, 2026
Merged

test(spanner): fix MutableCredentialsExample sample#13006
sakthivelmanii merged 1 commit intomainfrom
fix_spanner_samples

Conversation

@sakthivelmanii
Copy link
Copy Markdown
Contributor

No description provided.

@sakthivelmanii sakthivelmanii requested review from a team as code owners May 5, 2026 13:34
@rahul2393 rahul2393 changed the title test(java-spanner): Fix MutableCredentialsExample sample test(spanner): Fix MutableCredentialsExample sample May 5, 2026
@rahul2393 rahul2393 changed the title test(spanner): Fix MutableCredentialsExample sample test(spanner): fix MutableCredentialsExample sample May 5, 2026
@rahul2393
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of google-cloud-spanner and libraries-bom in the sample project POM files and adds an import for AtomicReference in MutableCredentialsExample.java. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google-cloud-spanner dependency version to 6.116.1 in the install-without-bom sample and the libraries-bom version to 26.80.0 in the snippets sample. It also adds an import for java.util.concurrent.atomic.AtomicReference in MutableCredentialsExample.java. I have no feedback to provide.

@sakthivelmanii sakthivelmanii merged commit b88cd64 into main May 5, 2026
128 of 129 checks passed
@sakthivelmanii sakthivelmanii deleted the fix_spanner_samples branch May 5, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants