chore(bqjdbc): enhance exception messages to include chained exception message#12996
Merged
chore(bqjdbc): enhance exception messages to include chained exception message#12996
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized utility class, BigQueryJdbcExceptionUtils, to standardize exception message formatting across the JDBC driver's exception hierarchy. By appending the cause's message to the primary error message, the changes improve diagnostic clarity. The feedback suggests making the utility class package-private to follow the principle of least privilege and refining the message formatting to consistently include the exception type for better debugging.
logachev
changed the title
Neenu1995
approved these changes
May 5, 2026
| super("Coercion error", cause); | ||
| LOG.severe("Coercion error", this); | ||
| super(BigQueryJdbcExceptionUtils.formatMessage("Coercion error", cause), cause); | ||
| LOG.severe(this.getMessage(), this); |
Contributor
There was a problem hiding this comment.
nit: My latest PR removes the severe logs from the exception classes. You can leave these unedited, it will be removed later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tools display to the user only top-level exception message. In order to avoid hiding underlying issues, modify JDBC messages to always include underlying reason if available.