Skip to content

feat: [health] new module for health#12993

Open
cloud-java-bot wants to merge 10 commits intomainfrom
new-library/health-mzeNy
Open

feat: [health] new module for health#12993
cloud-java-bot wants to merge 10 commits intomainfrom
new-library/health-mzeNy

Conversation

@cloud-java-bot
Copy link
Copy Markdown
Collaborator

Generated by @jinseopkim0 via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-library --api-shortname "health" --name-pretty "Google Health API" --api-description "The Google Health API lets you view and manage health and fitness metrics and measurement data." --proto-path "google/devicesandservices/health/v4" --product-docs "https://developers.google.com/health/api" --rpc-docs "https://developers.google.com/health/api/reference/rpc" 

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner May 4, 2026 19:23
@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the generation_config.yaml file by moving the common-protos, iam, and showcase entries to maintain alphabetical order. It also introduces a new entry for the Google Health API and removes a trailing space in the Map Management API description. Feedback was provided to address formatting inconsistencies in the common-protos entry, specifically regarding line breaks for documentation and dependency fields and an unnecessary blank line.

Comment thread generation_config.yaml Outdated
Comment on lines +657 to +665
client_documentation:
https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history
distribution_name: com.google.api.grpc:proto-google-common-protos
excluded_dependencies:
proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent
excluded_poms: proto-google-common-protos-bom,proto-google-common-protos
library_type: OTHER

GAPICs:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The formatting for the common-protos entry is inconsistent with other entries in this file. Specifically, the values for client_documentation and excluded_dependencies should be on the same line as their respective keys, and the unnecessary blank line before GAPICs should be removed to maintain consistency with other library entries.

  client_documentation: https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history
  distribution_name: com.google.api.grpc:proto-google-common-protos
  excluded_dependencies: proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent
  excluded_poms: proto-google-common-protos-bom,proto-google-common-protos
  library_type: OTHER
  GAPICs:

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 4, 2026

Here is the summary of changes.

You are about to add 63 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jinseopkim0 jinseopkim0 enabled auto-merge (squash) May 4, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owlbot:run Add this label to trigger the Owlbot post processor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants