feat: [health] new module for health#12993
Conversation
There was a problem hiding this comment.
Code Review
This pull request reorganizes the generation_config.yaml file by moving the common-protos, iam, and showcase entries to maintain alphabetical order. It also introduces a new entry for the Google Health API and removes a trailing space in the Map Management API description. Feedback was provided to address formatting inconsistencies in the common-protos entry, specifically regarding line breaks for documentation and dependency fields and an unnecessary blank line.
| client_documentation: | ||
| https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history | ||
| distribution_name: com.google.api.grpc:proto-google-common-protos | ||
| excluded_dependencies: | ||
| proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent | ||
| excluded_poms: proto-google-common-protos-bom,proto-google-common-protos | ||
| library_type: OTHER | ||
|
|
||
| GAPICs: |
There was a problem hiding this comment.
The formatting for the common-protos entry is inconsistent with other entries in this file. Specifically, the values for client_documentation and excluded_dependencies should be on the same line as their respective keys, and the unnecessary blank line before GAPICs should be removed to maintain consistency with other library entries.
client_documentation: https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history
distribution_name: com.google.api.grpc:proto-google-common-protos
excluded_dependencies: proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent
excluded_poms: proto-google-common-protos-bom,proto-google-common-protos
library_type: OTHER
GAPICs:
Generated by @jinseopkim0 via generate_new_client_hermetic_build.yaml
Command used: