chore: improve monorepo migration tooling#12962
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a migration script for java-pubsub and updates several utility scripts for workflow transformation, generation configuration, and root POM management. The feedback highlights a critical issue where appending YAML directly to the generation config results in an invalid structure and loses deduplication logic. Additionally, there are recommendations to move imports to the top of the file for PEP 8 compliance and to harden the regex-based sorting logic in the POM update script to prevent potential runtime errors.
Updates migration automation scripts as part of the effort to migrate java-pubsub into the monorepo. Refines generation_config.yaml updating logic to prevent data loss, patches root POM sorting to preserve original formatting, and adapts CI transformers to maintain standard Clirr execution steps.
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
from
4b4bc1e to
edff92a
Compare
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
from
cc6fc8c to
a2e4fd7
Compare
…depth constraints
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
2 times, most recently
from
1a4212b to
02733fb
Compare
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
from
6a7e78c to
ba75e49
Compare
… BOM substitution guards
meltsufin
changed the title
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
2 times, most recently
from
6d7b0c8 to
ac1082e
Compare
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
from
ac1082e to
29b2dda
Compare
…e in conformance scripts
… reactor pom to support CI linters
…r linter test-proxy exclusions
…ide migrated CI workflows
…r testing utilities
…he for proxy imports support
meltsufin
force-pushed
the
chore/pubsub-migration-tooling
branch
2 times, most recently
from
576baac to
b28142b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates migration automation scripts as part of the effort to migrate java-pubsub, java-firestore, and java-bigtable into the monorepo.