feat(spanner): support caller-owned OpenTelemetry client metrics - #20388
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to export Spanner's built-in client metrics to a caller-owned OpenTelemetry pipeline via the new ClientMetricsProvider configuration option. To support this, the internal metrics tracing system was refactored to handle multiple metrics sinks (e.g., native Cloud Monitoring and OpenTelemetry) simultaneously. The feedback recommends improving resource cleanup within the newBuiltinMetricsTracerFactory constructor by using named return errors and a deferred block to automatically clean up the newly created meter provider and exporter if the initialization fails.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
force-pushed
the
fm/spanner-go-clientmetrics-otel-b1
branch
from
August 18, 2026 20:13
27e5296 to
5912ac0
Compare
… setup fails newBuiltinMetricsTracerFactory creates the Cloud Monitoring meter provider and exporter before registering metric sinks. If a later sink registration failed, the constructor returned the error without stopping the exporter or shutting down the meter provider it had created. Use a named error return and a deferred cleanup so the factory releases only the resources it owns on any failure path; a caller-owned ClientMetricsProvider is never shut down.
olavloite
approved these changes
Aug 24, 2026
| } | ||
|
|
||
| func newBuiltinMetricsTracerFactory(ctx context.Context, dbpath, compression string, isAFEBuiltInMetricEnabled, isEnableGRPCBuiltInMetrics bool, metricsProvider metric.MeterProvider, opts ...option.ClientOption) (*builtinMetricsTracerFactory, error) { | ||
| func newBuiltinMetricsTracerFactory(ctx context.Context, dbpath, compression string, isAFEBuiltInMetricEnabled, isEnableGRPCBuiltInMetrics bool, metricsProvider, clientMetricsProvider metric.MeterProvider, opts ...option.ClientOption) (tracerFactory *builtinMetricsTracerFactory, err error) { |
Contributor
There was a problem hiding this comment.
For a follow-up PR: This method could use a refactor and be split into smaller parts. It is not really easy to read as it is now....
rahul2393
pushed a commit
that referenced
this pull request
Aug 24, 2026
🤖 I have created a release *beep* *boop* --- ## [1.95.0](spanner/v1.94.0...spanner/v1.95.0) (2026-08-24) ### Features * **spanner:** Penalize channels that returned Unavailable or ResourceExhausted in the dynamic channel pool picker ([#20390](#20390)) ([e1feec4](e1feec4)) * **spanner:** Support caller-owned OpenTelemetry client metrics ([#20388](#20388)) ([f1e77ce](f1e77ce)) ### Bug Fixes * **spanner:** Stop leaking endpointLatencyRegistry cleanup goroutine ([#20416](#20416)) ([95bbcc7](95bbcc7)), refs [#14488](#14488) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Reference: go/built-in-metric-custom-export
Java PR: googleapis/google-cloud-java#13741