Add definition for user agent override field.#78
Open
belm0 wants to merge 1 commit intogoogleanalytics:masterfrom
Open
Add definition for user agent override field.#78belm0 wants to merge 1 commit intogoogleanalytics:masterfrom
belm0 wants to merge 1 commit intogoogleanalytics:masterfrom
Conversation
loonychewy
pushed a commit
to loonychewy/google-analytics-plugin-for-unity
that referenced
this pull request
Apr 14, 2016
…agent - Implemented using a mixture of code from the following sources 1. googleanalytics#78 1.1 For user agent override 2. googleanalytics#94 2.1 For the user agent string for Windows and OS X. 2.2 Includes a bit of extra code to fix a bug in Unity 4.6 where it reports Windows 10 as Windows 8.1 (6.3.10XXX), where the build number is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use case: allows apps to override user agent, notably used with SetOnTracker so that all hits contain OS information and thereby the stock OS tracking reporting of Analytics can be utilized
(Aside: I have an implementation of the user agent string synthesis which I could contribute to the library. Coverage is partial at this point, supporting Windows and Mac.)