This repository was archived by the owner on Aug 25, 2025. It is now read-only.
[fix 411] Bump go version to 1.23 #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
head1328
approved these changes
Nov 25, 2024
alexandear
reviewed
Jan 15, 2025
| @@ -1,10 +1,12 @@ | |||
| module github.com/google/wire | |||
|
|
|||
| go 1.12 | |||
| go 1.23 | |||
There was a problem hiding this comment.
Can we bump to 1.22 to support the most recent 2 Go versions? Like https://go.dev/doc/devel/release#policy
There was a problem hiding this comment.
Well 1.24 released so can we set to 1.23 now?
There was a problem hiding this comment.
Well 1.24 released so can we set to 1.23 now?
There was a problem hiding this comment.
FWIW, I thanks to go 1.24's latest "tool" feature, we no longer need any new versions… we can just invoke it as a tool, which will recompile it every time.
skovtunenko
approved these changes
Feb 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Go 1.23.0 has several new features, which have no direct bearing on wire's ability to reflect, but, which disallow using a binary built with an older go from running.