Skip to content

PRP: Mise tools extractor - #1423

Merged
copybara-service[bot] merged 7 commits into
google:mainfrom
joernNNN:mise-extractor
Jan 20, 2026
Merged

copybara-service[bot] merged 7 commits into
google:mainfrom
joernNNN:mise-extractor

Conversation

@joernNNN

@joernNNN joernNNN commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

@joernNNN
joernNNN marked this pull request as ready for review October 4, 2025 19:12

@erikvarga erikvarga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for delay and thanks for your patience throughout the PRP freeze. We're now resuming reviews of PRP PRs.

Comment thread extractor/filesystem/runtime/mise/testdata/not-valid-toml.toml Outdated
Comment thread docs/supported_inventory_types.md
Comment thread extractor/filesystem/runtime/mise/mise.go Outdated
Comment thread extractor/filesystem/runtime/mise/mise.go
Comment thread extractor/filesystem/runtime/mise/mise_test.go Outdated

@erikvarga erikvarga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general now, note the failing tests though

@copybara-service
copybara-service Bot merged commit de8dcfa into google:main Jan 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants