Update jdk 17 version to unbreak the PDFBox build #13860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR moves to temurin from Oracle for jdk 17. This felt easier for the license issue with Oracle, but it hurts to have two different jdks. We may want to figure out if we need jdk 15, which isn't LTS and not supported anymore. That work would be on a different PR/ticket. |
tballison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version of jdk17 to 17.0.16+8.
This update is required to build PDFBox: https://issues.apache.org/jira/browse/PDFBOX-6051?focusedCommentId=18015721&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-18015721
PDFBox is no longer building in ossfuzz:
https://oss-fuzz-build-logs.storage.googleapis.com/log-907a41b7-64fc-4a03-a728-a4b5bbf8042a.txt
and the error message is consistent with PDFBOX-6051:
I confirmed locally that
infra/base-images/all.shcreates a jvm base that in turn allows pdfbox to build.I have NOT tested this across all projects.