Fix generated proto exports in Windows shared builds - #5346
Open
PharahAmari wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PharahAmari
force-pushed
the
fix/windows-proto-shared-exports
branch
from
September 7, 2026 09:03
aeaf4d5 to
6937b24
Compare
Mizux
reviewed
Sep 7, 2026
Comment on lines
53
to
55
| list(APPEND OR_TOOLS_COMPILE_DEFINITIONS "OR_ORTOOLS_PROTO_DLL=__declspec(dllimport)") | ||
| else() | ||
| list(APPEND OR_TOOLS_COMPILE_DEFINITIONS "OR_ORTOOLS_PROTO_DLL=") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When generated proto object libraries are compiled as part of a shared MSVC build,
OR_TOOLS_COMPILE_DEFINITIONScan provide the consumer-sidedllimportdefinition while the target also adds its privatedllexportdefinition. Both definitions then appear on the compiler command line. Ifdllimportwins by command-line ordering, MSVC rejects definitions of generated static data members with C2491.Change
Filter the current generated proto target's consumer-side import macro out of the common compile definitions before applying the target's explicit interface/private import/export definitions.
Non-MSVC and static builds are unchanged.
Validation
dllexportdefinition.ortools.dlland all Python extension modules.