Log resolution trace and lookups#2975
Open
jaschdoc wants to merge 1 commit into
Open
Conversation
jaschdoc
force-pushed
the
log-dep-graph
branch
13 times, most recently
from
671862b to
02a36a8
Compare
jaschdoc
changed the title
Collaborator
|
All this logging is based on naked calls to |
troelsbjerre
requested changes
Jun 12, 2026
troelsbjerre
left a comment
troelsbjerre
left a comment
Collaborator
There was a problem hiding this comment.
All this logging is based on naked calls to File.appendText. Wouldn't it be preferable to buffer these writes, and perhaps wrap the logger destination in a PrintStream?
Comment on lines
+540
to
+545
| if (it.exists()) { | ||
| it.delete() | ||
| it.createNewFile() | ||
| } else { | ||
| it.createNewFile() | ||
| } |
Collaborator
There was a problem hiding this comment.
File.delete() just returns false when the file doesn't exist, so the if-else can be replaced by the first branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new log file to the logs for incremental builds including which symbols were looked up by which files. Additionally, the lookup graph is now both written as a log and as a graphviz file.