Skip to content

fix annotation value array type on native&js target#1508

Open
qdsfdhvh wants to merge 2 commits into
google:mainfrom
qdsfdhvh:patch-1
Open

fix annotation value array type on native&js target#1508
qdsfdhvh wants to merge 2 commits into
google:mainfrom
qdsfdhvh:patch-1

Conversation

@qdsfdhvh

@qdsfdhvh qdsfdhvh commented Aug 25, 2023

Copy link
Copy Markdown

on nativie & js target, when annotation value array type, result is Array<*>, I tried removed the throw and save it.

fix #1487, fix #1503

@google-cla

google-cla Bot commented Aug 25, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@neetopia neetopia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception is meant to avoid silent failures, can you keep the throw statement, and add one more else if before the last else clause to address this case?

@qdsfdhvh

qdsfdhvh commented Sep 8, 2023

Copy link
Copy Markdown
Author

I've considered else if before, but I'm not sure how to write it, I tried to add a judgement about method.returnType and result::class.type, how about that?

@github-actions github-actions Bot added the stale label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants